Stream: git-wasmtime

Topic: wasmtime / PR #8048 winch: Always free the source registe...

Wasmtime GitHub notifications bot (Mar 05 2024 at 13:16):

saulecabrera requested fitzgen for a review on PR #8048.

Wasmtime GitHub notifications bot (Mar 05 2024 at 13:16):

saulecabrera requested wasmtime-compiler-reviewers for a review on PR #8048.

Wasmtime GitHub notifications bot (Mar 05 2024 at 13:16):

saulecabrera requested wasmtime-core-reviewers for a review on PR #8048.

Wasmtime GitHub notifications bot (Mar 05 2024 at 13:16):

saulecabrera opened PR #8048 from saulecabrera:winch-always-free-src-in-store to bytecodealliance:main:

This commit fixes a bug where when an out-of-bounds access is detected at compile time, emit_wasm_store was failing to free the source register. By the time the address is computed, the register is already allocated, independently if it's used or not, it must be freed.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 05 2024 at 15:44):

github-actions[bot] commented on PR #8048:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Mar 05 2024 at 15:58):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Mar 05 2024 at 16:29):

saulecabrera merged PR #8048.

Last updated: Oct 23 2024 at 20:03 UTC