Stream: git-wasmtime

Topic: wasmtime / PR #8027 Add CLI flags for instance limits

Wasmtime GitHub notifications bot (Feb 28 2024 at 23:54):

abrown opened PR #8027 from abrown:cli-limits to bytecodealliance:main:

While experimenting with wasmtime serve, I found it helpful to be able to configure some of the maximum limits of the various objects stored in the pooling allocator. This change surfaces some new -O total-* flags for controlling these limits from the command line.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Feb 28 2024 at 23:54):

abrown requested alexcrichton for a review on PR #8027.

Wasmtime GitHub notifications bot (Feb 28 2024 at 23:54):

abrown requested wasmtime-core-reviewers for a review on PR #8027.

Wasmtime GitHub notifications bot (Feb 28 2024 at 23:56):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Feb 28 2024 at 23:56):

abrown created PR review comment:

Another option here, since all of these default to the same number currently, is to have a single flag --total-pool-slots or the like that sets all of these together. But maybe someone wants to control these in a bit more fine-grained way, so I went down this route instead.

Wasmtime GitHub notifications bot (Feb 29 2024 at 01:17):

alexcrichton submitted PR review:

Agreed having all the knobs here is fine, the goal is to reflect the options of Config on the CLI and this does that well.

Mind adding pool or pooling at the front of the options though to emphasize that they're only used as configuration to the pooling allocator?

Wasmtime GitHub notifications bot (Mar 01 2024 at 18:06):

abrown updated PR #8027.

Wasmtime GitHub notifications bot (Mar 01 2024 at 19:19):

abrown requested alexcrichton for a review on PR #8027.

Wasmtime GitHub notifications bot (Mar 01 2024 at 19:49):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Mar 01 2024 at 20:19):

alexcrichton merged PR #8027.

Last updated: Nov 22 2024 at 16:03 UTC