Stream: git-wasmtime

Topic: wasmtime / PR #8016 Fix a memory leak found in fuzzing

Wasmtime GitHub notifications bot (Feb 28 2024 at 18:28):

alexcrichton opened PR #8016 from alexcrichton:fix-leak to bytecodealliance:main:

This fixes a mistake introduced in #7996 where a global.get used to initialize a table did not properly drop previous items in the table causing them to leak as the reference count was not decremented.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Feb 28 2024 at 18:28):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8016.

Wasmtime GitHub notifications bot (Feb 28 2024 at 18:28):

alexcrichton requested fitzgen for a review on PR #8016.

Wasmtime GitHub notifications bot (Feb 28 2024 at 19:07):

fitzgen submitted PR review:

Regression test in tests/all/gc.rs? Can use the SetFlagOnDrop helper.

Wasmtime GitHub notifications bot (Feb 28 2024 at 19:19):

alexcrichton commented on PR #8016:

Actually, there's another issue I've found, so I've opted for a larger refactor in https://github.com/bytecodealliance/wasmtime/pull/8018 to fix this (test included over there)

Wasmtime GitHub notifications bot (Feb 28 2024 at 19:19):

alexcrichton closed without merge PR #8016.

Last updated: Nov 22 2024 at 16:03 UTC