Stream: git-wasmtime

Topic: wasmtime / PR #7996 Support `global.get` in more constant...

Wasmtime GitHub notifications bot (Feb 24 2024 at 20:26):

alexcrichton opened PR #7996 from alexcrichton:update-spec-test-suite to bytecodealliance:main:

This commit updates Wasmtime to support global.get in constant expressions when located in table initializers and element segments. Pre-reference-types this never came up because there was no valid global.get that would typecheck. After the reference-types proposal landed however this became possible but Wasmtime did not support it. This was surfaced in #6705 when the spec test suite was updated and has a new test that exercises this functionality.

This commit both updates the spec test suite and additionally adds support for this new form of element segment and table initialization expression.

The fact that Wasmtime hasn't supported this until now also means that we have a gap in our fuzz-testing infrastructure. The wasm-smith generator is being updated in bytecodealliance/wasm-tools#1426 to generate modules with this particular feature and I've tested that with that PR fuzzing here eventually generates an error before this PR.

Closes #6705

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Feb 24 2024 at 20:26):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7996.

Wasmtime GitHub notifications bot (Feb 24 2024 at 20:26):

alexcrichton requested pchickey for a review on PR #7996.

Wasmtime GitHub notifications bot (Feb 26 2024 at 14:30):

fitzgen requested fitzgen for a review on PR #7996.

Wasmtime GitHub notifications bot (Feb 26 2024 at 14:36):

fitzgen submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (Feb 26 2024 at 15:16):

fitzgen merged PR #7996.

Last updated: Nov 22 2024 at 17:03 UTC