Stream: git-wasmtime

Topic: wasmtime / PR #7993 Winch: Use Option<u8> for register in...

Wasmtime GitHub notifications bot (Feb 28 2024 at 18:10):

jeffcharles edited PR #7993.

Wasmtime GitHub notifications bot (Feb 28 2024 at 18:11):

jeffcharles edited PR #7993:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Returning an Option<u8> to track the register index allows us to support parameter lists that are longer than 255 since we can return None instead of overflowing when we hit the the maximum value for u8. It looks like v8 supports 1000 params.

Wasmtime GitHub notifications bot (Feb 28 2024 at 18:12):

jeffcharles requested saulecabrera for a review on PR #7993.

Wasmtime GitHub notifications bot (Feb 28 2024 at 20:54):

saulecabrera submitted PR review.

Wasmtime GitHub notifications bot (Feb 28 2024 at 20:55):

saulecabrera commented on PR #7993:

Thanks for the heads up @fitzgen; Winch is already compliant with those limits (via wasmparser), the limits that we're discussing are for ISA register counts.

Wasmtime GitHub notifications bot (Feb 28 2024 at 21:21):

saulecabrera merged PR #7993.

Last updated: Oct 23 2024 at 20:03 UTC