Stream: git-wasmtime

Topic: wasmtime / PR #7986 Split out `TypeRegistry`'s open-coded...

Wasmtime GitHub notifications bot (Feb 23 2024 at 01:51):

fitzgen opened PR #7986 from fitzgen:slab to bytecodealliance:main:

First of all, it is just a nice separation of concerns.

Second of all, as I design the GC rooting APIs for Wasmtime's upcoming Wasm GC support, I want this same thing and I'd rather not open code it multiple times.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Feb 23 2024 at 01:51):

fitzgen requested alexcrichton for a review on PR #7986.

Wasmtime GitHub notifications bot (Feb 23 2024 at 01:51):

fitzgen requested wasmtime-core-reviewers for a review on PR #7986.

Wasmtime GitHub notifications bot (Feb 23 2024 at 01:51):

fitzgen requested wasmtime-default-reviewers for a review on PR #7986.

Wasmtime GitHub notifications bot (Feb 23 2024 at 02:14):

elliottt submitted PR review:

This seems good to me! We could probably use this for the wasi table in wasmtime-wasi as well, as it looks pretty similar in its implementation :)

Wasmtime GitHub notifications bot (Feb 23 2024 at 02:14):

elliottt submitted PR review:

This seems good to me! We could probably use this for the wasi table in wasmtime-wasi as well, as it looks pretty similar in its implementation :)

Wasmtime GitHub notifications bot (Feb 23 2024 at 02:14):

elliottt created PR review comment:

Does this use NonZeroU32 to ensure that Option<Id> takes up four bytes?

Wasmtime GitHub notifications bot (Feb 23 2024 at 02:17):

elliottt submitted PR review:

This seems good to me! We could probably use this for the ResourceTable as well, as it looks pretty similar in its implementation :)

Wasmtime GitHub notifications bot (Feb 23 2024 at 02:23):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Feb 23 2024 at 02:23):

fitzgen created PR review comment:

Yep, and this also aligns with how VMSharedTypeIndex reserves u32::MAX for its default/null value.

Wasmtime GitHub notifications bot (Feb 23 2024 at 02:24):

fitzgen commented on PR #7986:

We could probably use this for the ResourceTable as well, as it looks pretty similar in its implementation :)

I believe Alex added a generation to that table, so it would need to do the layering described in the docs. Might make sense to add a generic implementation of that layering to this crate if we make ResourceTable use this as an implementation detail.

Wasmtime GitHub notifications bot (Feb 23 2024 at 04:44):

github-actions[bot] commented on PR #7986:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Feb 23 2024 at 16:23):

fitzgen merged PR #7986.

Last updated: Nov 22 2024 at 16:03 UTC