alexcrichton opened PR #7984 from alexcrichton:no-wasi-submodule
to bytecodealliance:main
:
Historically the
WASI
submodule in this repository was used to pull the sources of the*.witx
files for preview1. This has never been used by thewasmtime-wasi
crate (which has its own copy in thecrates/wasi/witx
folder) and was only ever used bywasi-common
. This submodule also served as a location for thewitx
crate itself.Neither of these are really needed any more as the
*.witx
files are unlikely to ever really change again. This commit removes the submodule entirely, as well as thepath
dependency onwitx
, and copies the*.witx
files in the same manner as thewasmtime-wasi
crate.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested fitzgen for a review on PR #7984.
alexcrichton requested wasmtime-core-reviewers for a review on PR #7984.
alexcrichton requested wasmtime-default-reviewers for a review on PR #7984.
alexcrichton updated PR #7984.
sunfishcode submitted PR review:
fewer submodules woo! :partying_face:
alexcrichton has enabled auto merge for PR #7984.
alexcrichton updated PR #7984.
alexcrichton has enabled auto merge for PR #7984.
alexcrichton updated PR #7984.
alexcrichton has enabled auto merge for PR #7984.
pchickey commented on PR #7984:
wasmtime-wasi does use the witxs and wiggle to generate out its preview 1 module interface, but I agree the submodule should go :)
alexcrichton merged PR #7984.
Last updated: Dec 23 2024 at 12:05 UTC