Stream: git-wasmtime

Topic: wasmtime / PR #7984 Remove the `WASI` submodule

Wasmtime GitHub notifications bot (Feb 22 2024 at 21:04):

alexcrichton opened PR #7984 from alexcrichton:no-wasi-submodule to bytecodealliance:main:

Historically the WASI submodule in this repository was used to pull the sources of the *.witx files for preview1. This has never been used by the wasmtime-wasi crate (which has its own copy in the crates/wasi/witx folder) and was only ever used by wasi-common. This submodule also served as a location for the witx crate itself.

Neither of these are really needed any more as the *.witx files are unlikely to ever really change again. This commit removes the submodule entirely, as well as the path dependency on witx, and copies the *.witx files in the same manner as the wasmtime-wasi crate.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Feb 22 2024 at 21:04):

alexcrichton requested fitzgen for a review on PR #7984.

Wasmtime GitHub notifications bot (Feb 22 2024 at 21:04):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7984.

Wasmtime GitHub notifications bot (Feb 22 2024 at 21:04):

alexcrichton requested wasmtime-default-reviewers for a review on PR #7984.

Wasmtime GitHub notifications bot (Feb 22 2024 at 21:11):

alexcrichton updated PR #7984.

Wasmtime GitHub notifications bot (Feb 22 2024 at 21:14):

sunfishcode submitted PR review:

fewer submodules woo! :partying_face:

Wasmtime GitHub notifications bot (Feb 22 2024 at 21:15):

alexcrichton has enabled auto merge for PR #7984.

Wasmtime GitHub notifications bot (Feb 22 2024 at 21:35):

alexcrichton updated PR #7984.

Wasmtime GitHub notifications bot (Feb 22 2024 at 21:35):

alexcrichton has enabled auto merge for PR #7984.

Wasmtime GitHub notifications bot (Feb 22 2024 at 22:08):

alexcrichton updated PR #7984.

Wasmtime GitHub notifications bot (Feb 22 2024 at 22:08):

alexcrichton has enabled auto merge for PR #7984.

Wasmtime GitHub notifications bot (Feb 22 2024 at 22:43):

pchickey commented on PR #7984:

wasmtime-wasi does use the witxs and wiggle to generate out its preview 1 module interface, but I agree the submodule should go :)

Wasmtime GitHub notifications bot (Feb 22 2024 at 22:51):

alexcrichton merged PR #7984.

Last updated: Oct 23 2024 at 20:03 UTC