Wasmtime GitHub notifications bot (Feb 22 2024 at 19:43): Wasmtime GitHub notifications bot (Feb 22 2024 at 19:43):elliottt opened PR #7982 from elliottt:trevor/winch-refactor-prologue to bytecodealliance:main:
Rework the winch prologue and epilogue definitions as default implementations in the
MacroAssemblertrait, naming the common sequence of frame setup, check stack, handle clobbers, and reserve space for locals. This change also allows us to remove the special prologue and epilogue functions from the trampoline module, and rely instead on the same function used by the normal function compilation path.As I moved the pinning of the vmctx register to after the prologue, this change had a pretty noisy effect on the filetests.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Feb 22 2024 at 19:43):elliottt requested wasmtime-compiler-reviewers for a review on PR #7982.
Wasmtime GitHub notifications bot (Feb 22 2024 at 19:43):elliottt requested abrown for a review on PR #7982.
Wasmtime GitHub notifications bot (Feb 22 2024 at 19:43):elliottt updated PR #7982.
Wasmtime GitHub notifications bot (Feb 22 2024 at 19:43):elliottt requested saulecabrera for a review on PR #7982.
Wasmtime GitHub notifications bot (Feb 22 2024 at 20:44):github-actions[bot] commented on PR #7982:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Feb 22 2024 at 20:50):saulecabrera submitted PR review:
One minor question. Else looks reasonable to me, thanks!
Wasmtime GitHub notifications bot (Feb 22 2024 at 20:50):saulecabrera submitted PR review:
One minor question. Else looks reasonable to me, thanks!
Wasmtime GitHub notifications bot (Feb 22 2024 at 20:50):saulecabrera created PR review comment:
Could we do
self.masm.epilogue(&self.callee_saved_regs, spill_size)here?
Wasmtime GitHub notifications bot (Feb 22 2024 at 22:13):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Feb 22 2024 at 22:13):elliottt created PR review comment:
We could, but at that point i wonder if we should move the stack allocation out of the prologue and epilogue. What do you think about not including the reserve/free calls?
Wasmtime GitHub notifications bot (Feb 22 2024 at 22:17):elliottt updated PR #7982.
Wasmtime GitHub notifications bot (Feb 22 2024 at 22:19):saulecabrera submitted PR review.
Wasmtime GitHub notifications bot (Feb 22 2024 at 22:19):saulecabrera created PR review comment:
Yeah, that makes sense to me as well.
Wasmtime GitHub notifications bot (Feb 22 2024 at 22:35):elliottt updated PR #7982.
Wasmtime GitHub notifications bot (Feb 22 2024 at 23:18):elliottt merged PR #7982.
Last updated: Dec 23 2024 at 12:05 UTC