Wasmtime GitHub notifications bot (Feb 22 2024 at 11:55): Wasmtime GitHub notifications bot (Feb 22 2024 at 11:55):uweigand opened PR #7978 from uweigand:reloc-offset to bytecodealliance:main:
When emitting a call to __tls_get_offset, the instruction needs to carry two relocations, a R_390_PLT32DBL targeting __tls_get_offset and a R_390_TLS_GDCALL targeting the TLS symbol. Specifically, the system linker expects to see these two relocation in that order.
However, the cranelift backend currently emits the relocations in reverse order - this unfortunately causes the linker to corrupt the instruction sequence when performing a TLS relaxation.
To fix this in the backend, I need support in machinst common code to emit a relocation at some offset to the instruction about to be emitted (e.g. the relocation should target two bytes into the 6-byte instruction that will be emitted next). I've added a new routine add_reloc_at_offset to that effect. This also allowed to simplify some existing code in the backend.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Feb 22 2024 at 11:55):uweigand requested abrown for a review on PR #7978.
Wasmtime GitHub notifications bot (Feb 22 2024 at 11:55):uweigand requested wasmtime-compiler-reviewers for a review on PR #7978.
Wasmtime GitHub notifications bot (Feb 22 2024 at 12:05):bjorn3 submitted PR review.
Wasmtime GitHub notifications bot (Feb 22 2024 at 12:05):bjorn3 created PR review comment:
Shouldn't both relocs be printed here?
Wasmtime GitHub notifications bot (Feb 22 2024 at 12:19):uweigand updated PR #7978.
Wasmtime GitHub notifications bot (Feb 22 2024 at 12:19):uweigand submitted PR review.
Wasmtime GitHub notifications bot (Feb 22 2024 at 12:19):uweigand created PR review comment:
Good point. I've fixed the disassembler to print multiple relocs on a single insn if present.
Wasmtime GitHub notifications bot (Feb 22 2024 at 21:25):abrown submitted PR review:
Makes sense to me.
Wasmtime GitHub notifications bot (Feb 22 2024 at 21:57):abrown merged PR #7978.
Last updated: Nov 22 2024 at 16:03 UTC