Stream: git-wasmtime

Topic: wasmtime / PR #7961 Write release notes for 18.0.0

Wasmtime GitHub notifications bot (Feb 20 2024 at 15:37):

alexcrichton opened PR #7961 from alexcrichton:relnotes to bytecodealliance:main:

Will backport after landing on main

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Feb 20 2024 at 15:37):

alexcrichton requested pchickey for a review on PR #7961.

Wasmtime GitHub notifications bot (Feb 20 2024 at 15:37):

alexcrichton requested wasmtime-default-reviewers for a review on PR #7961.

Wasmtime GitHub notifications bot (Feb 20 2024 at 18:26):

pchickey commented on PR #7961:

Because github doesn't allow multi-line suggestions, the changelog for wasi-common should be tweaked:

* Support for the old `wasi-common` crate and the original implementation of
  "WASIp1" aka "preview1" is being deprecated in the `wasmtime-wasi` crate.
  Users should migrate to the  `wasmtime_wasi::preview2` implementation, which
  supports both WASIp1 and WASIp2, as in the next release the
`wasi-common`-based reexports of `wasmtime-wasi` will be deleted.
  [#7881](https://github.com/bytecodealliance/wasmtime/pull/7881)

Wasmtime GitHub notifications bot (Feb 20 2024 at 18:26):

pchickey edited a comment on PR #7961:

Because github doesn't allow multi-line suggestions, the changelog for wasi-common should be tweaked:

* Support for the old `wasi-common` crate and the original implementation of
  "WASIp1" aka "preview1" is being deprecated in the `wasmtime-wasi` crate.
  Users should migrate to the  `wasmtime_wasi::preview2` implementation, which
  supports both WASIp1 and WASIp2, as in the next release the
  `wasi-common`-based reexports of `wasmtime-wasi` will be deleted.
  [#7881](https://github.com/bytecodealliance/wasmtime/pull/7881)

Wasmtime GitHub notifications bot (Feb 20 2024 at 18:32):

alexcrichton updated PR #7961.

Wasmtime GitHub notifications bot (Feb 20 2024 at 18:32):

alexcrichton commented on PR #7961:

Updated :+1:

Wasmtime GitHub notifications bot (Feb 20 2024 at 18:34):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Feb 20 2024 at 18:35):

alexcrichton has enabled auto merge for PR #7961.

Wasmtime GitHub notifications bot (Feb 20 2024 at 19:26):

alexcrichton merged PR #7961.

Wasmtime GitHub notifications bot (Feb 20 2024 at 19:29):

krn-sebastiaan commented on PR #7961:

Because github doesn't allow multi-line suggestions, the changelog for wasi-common should be tweaked:

It does, click on the blue +-sign and drag down until the desired line.

Dragging up won't work.

https://github.com/bytecodealliance/wasmtime/assets/159554287/8eb7e2f6-9ecb-46cf-9c3e-8f6dfcee94d7

Last updated: Nov 22 2024 at 16:03 UTC