fitzgen opened PR #7953 from fitzgen:misc-call-speedups
to bytecodealliance:main
:
This commit makes the following changes:
A handful of
#[inline]
annotations.A couple cases of splitting out uncommon/slow paths from
#[inline]
-annotated functions into their own non-#[inline]
-annotated functions.Remove a call to
mpk::is_supported()
in async context construction. It is sufficient to just checkself.pkey.is_some()
since if mpk isn't supported we won't have a pkey, if we do have a pkey mpk must have been supported for us to get it, and even if mpk is supported, if we don't have a pkey we don't need to do anything here.Criterion benchmark results:
sync/no-hook/core - host-to-wasm - typed - nop-params-and-results time: [25.214 ns 25.322 ns 25.443 ns] change: [-21.901% -20.227% -18.749%] (p = 0.00 < 0.05) Performance has improved.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
fitzgen requested pchickey for a review on PR #7953.
fitzgen requested wasmtime-core-reviewers for a review on PR #7953.
github-actions[bot] commented on PR #7953:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
alexcrichton submitted PR review.
alexcrichton merged PR #7953.
Last updated: Dec 23 2024 at 12:05 UTC