Wasmtime GitHub notifications bot (Feb 16 2024 at 01:14): Wasmtime GitHub notifications bot (Feb 16 2024 at 01:14):fitzgen opened PR #7950 from fitzgen:traps-tests-and-rust-backtrace to bytecodealliance:main:
Instead of asserting exact error messages, which
anyhowauto adds Rust backtrace to on nightly, assert that the important bits are there.Split out from #7943.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Feb 16 2024 at 01:14):fitzgen requested wasmtime-core-reviewers for a review on PR #7950.
Wasmtime GitHub notifications bot (Feb 16 2024 at 01:14):fitzgen requested alexcrichton for a review on PR #7950.
Wasmtime GitHub notifications bot (Feb 16 2024 at 16:06):alexcrichton submitted PR review:
Personally I find it pretty helpful to have exhaustive assertions (ish) to get a better picture of what the error message looks like. It looks like
anyhowappendsStack backtrace: ...at the end of the message, so could all of these assertions change fromassert_eq!toassert!(s.contains(...))perhaps?
Wasmtime GitHub notifications bot (Feb 16 2024 at 16:32):fitzgen updated PR #7950.
Wasmtime GitHub notifications bot (Feb 16 2024 at 16:32):fitzgen commented on PR #7950:
so could all of these assertions change from
assert_eq!toassert!(s.contains(...))perhaps?Done!
Wasmtime GitHub notifications bot (Feb 16 2024 at 16:50):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Feb 16 2024 at 17:21):alexcrichton merged PR #7950.
Last updated: Nov 22 2024 at 16:03 UTC