Stream: git-wasmtime

Topic: wasmtime / PR #7950 Allow `traps.rs` tests to pass even w...


view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2024 at 01:14):

fitzgen opened PR #7950 from fitzgen:traps-tests-and-rust-backtrace to bytecodealliance:main:

Instead of asserting exact error messages, which anyhow auto adds Rust backtrace to on nightly, assert that the important bits are there.

Split out from #7943.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2024 at 01:14):

fitzgen requested wasmtime-core-reviewers for a review on PR #7950.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2024 at 01:14):

fitzgen requested alexcrichton for a review on PR #7950.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2024 at 16:06):

alexcrichton submitted PR review:

Personally I find it pretty helpful to have exhaustive assertions (ish) to get a better picture of what the error message looks like. It looks like anyhow appends Stack backtrace: ... at the end of the message, so could all of these assertions change from assert_eq! to assert!(s.contains(...)) perhaps?

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2024 at 16:32):

fitzgen updated PR #7950.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2024 at 16:32):

fitzgen commented on PR #7950:

so could all of these assertions change from assert_eq! to assert!(s.contains(...)) perhaps?

Done!

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2024 at 16:50):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2024 at 17:21):

alexcrichton merged PR #7950.


Last updated: Dec 23 2024 at 12:05 UTC