Stream: git-wasmtime

Topic: wasmtime / PR #7949 winch: Ensure correct handling of lib...

Wasmtime GitHub notifications bot (Feb 15 2024 at 21:08):

saulecabrera opened PR #7949 from saulecabrera:fix-fuzz-bug-libcalls to bytecodealliance:main:

This commit fixes a fuzz bug where modules involving known libcalls would fail to compile given that they were unconditionally treated as colocated libcalls.

This bug is only reproducible in non sse41 environments, given that some operations like floor default to libcalls in this case. The use_colocated_libcalls setting is not configurable within Wasmtime and as such, they should be loaded into a register prior to emitting the call. This will also ensure that the right 8-byte absolute relocation is used.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Feb 15 2024 at 21:08):

saulecabrera requested wasmtime-compiler-reviewers for a review on PR #7949.

Wasmtime GitHub notifications bot (Feb 15 2024 at 21:08):

saulecabrera requested elliottt for a review on PR #7949.

Wasmtime GitHub notifications bot (Feb 15 2024 at 21:44):

saulecabrera commented on PR #7949:

I'm unsure if there's an additional way to test this one aside from the filetests.

Wasmtime GitHub notifications bot (Feb 15 2024 at 23:44):

github-actions[bot] commented on PR #7949:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "cranelift", "winch"

Thus the following users have been cc'd because of the following labels:

• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Feb 15 2024 at 23:56):

saulecabrera updated PR #7949.

Wasmtime GitHub notifications bot (Feb 16 2024 at 05:57):

elliottt submitted PR review:

This looks good to me! As far as testing goes, this was caught by fuzzing so I think we're good. We could always look into running some of the spec tests with different codegen configurations, but that probably still won't catch as much as fuzzing will.

Wasmtime GitHub notifications bot (Feb 16 2024 at 13:42):

saulecabrera merged PR #7949.

Last updated: Nov 22 2024 at 17:03 UTC