Stream: git-wasmtime

Topic: wasmtime / PR #7932 Fully enable Winch in the `differenti...

Wasmtime GitHub notifications bot (Feb 14 2024 at 00:06):

alexcrichton requested saulecabrera for a review on PR #7932.

Wasmtime GitHub notifications bot (Feb 14 2024 at 00:06):

alexcrichton requested elliottt for a review on PR #7932.

Wasmtime GitHub notifications bot (Feb 14 2024 at 00:06):

alexcrichton opened PR #7932 from alexcrichton:fuzz-winch to bytecodealliance:main:

This commit fully enables usage of Winch in the differential fuzzer against all other engines with no special cases. I attempted enabling winch for the other fuzzers as well but Winch doesn't currently implement all methods for generating various trampolines required so it's currently only limited to the differential fuzzer.

This adds Winch as an "engine" and additionally ensures that when configured various wasm proposals are disabled that Winch doesn't support (similar to how enabling wasmi disables proposals that wasmi doesn't support).

This does reduce fuzzing of Winch slightly in that the reference-types proposal is completely disabled for Winch rather than half-enabled where Winch doesn't implement externref operations yet but does implement funcref operations. This, however, enables integrating it more cleanly into the rest of the fuzzing infrastructure with fewer special cases.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Feb 14 2024 at 00:06):

alexcrichton requested wasmtime-fuzz-reviewers for a review on PR #7932.

Wasmtime GitHub notifications bot (Feb 14 2024 at 00:06):

alexcrichton requested pchickey for a review on PR #7932.

Wasmtime GitHub notifications bot (Feb 14 2024 at 00:06):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7932.

Wasmtime GitHub notifications bot (Feb 14 2024 at 02:44):

github-actions[bot] commented on PR #7932:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "fuzzing"

Thus the following users have been cc'd because of the following labels:

• fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Feb 14 2024 at 11:48):

saulecabrera submitted PR review:

Thanks for working on this!

This does reduce fuzzing of Winch slightly in that the reference-types proposal is completely disabled for Winch rather than half-enabled where Winch doesn't implement externref operations yet but does implement funcref operations.

I think this is fine, we're starting the work on reference types, so we'd be able permanently enable fuzzing for funcref and externref soon-ish.

Given this change, I've taken the liberty to add myself to oss-fuzz (https://github.com/google/oss-fuzz/pull/11602), as I'd like to monitor more closely any Winch fuzz bugs. Let me know if you're ok with that change.

Wasmtime GitHub notifications bot (Feb 14 2024 at 15:11):

alexcrichton commented on PR #7932:

Let me know if you're ok with that change.

Definitely!

Wasmtime GitHub notifications bot (Feb 14 2024 at 15:42):

alexcrichton merged PR #7932.

Last updated: Dec 23 2024 at 12:05 UTC