Stream: git-wasmtime

Topic: wasmtime / PR #7926 Return correct fs errors on the proxy...

Wasmtime GitHub notifications bot (Feb 13 2024 at 15:50):

alexcrichton requested fitzgen for a review on PR #7926.

Wasmtime GitHub notifications bot (Feb 13 2024 at 15:50):

alexcrichton opened PR #7926 from alexcrichton:fix-proxy-adapter-fs-interaction to bytecodealliance:main:

This commit fixes an issue with the proxy adapter where if the proxy program attempted to look at prestat items, which wasi-libc always does on startup, it would invoke fd_prestat_get and receive ERRNO_NOTSUP in response (the standard response when using the
cfg_filesystem_available! macro). This error code is unexpected by wasi-libc and causes wasi-libc to abort. The PR here is to instead return ERRNO_BADF which is indeed expected by wasi-libc and is recognized as meaning "that prestat isn't available".

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Feb 13 2024 at 15:50):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7926.

Wasmtime GitHub notifications bot (Feb 13 2024 at 15:52):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Feb 13 2024 at 15:56):

alexcrichton has enabled auto merge for PR #7926.

Wasmtime GitHub notifications bot (Feb 13 2024 at 16:40):

alexcrichton merged PR #7926.

Last updated: Dec 23 2024 at 12:05 UTC