Wasmtime GitHub notifications bot (Feb 12 2024 at 18:20): Wasmtime GitHub notifications bot (Feb 12 2024 at 18:20):alexcrichton opened PR #7919 from alexcrichton:x64-float-lwoering to bytecodealliance:main:
This commit adds a general purpose lowering for the
fcvt_from_uintinstruction in addition to the previously specialized lowering for what the wasm frontend produces. This is unlikely to get triggered much from the wasm frontend except when intermediate optimizations change the shape of code. The goal of this commit is to address issues such as those identified in #7915 and historically by ensuring that there's a lowering for the instruction for all input types instead of trying to massage the input into the right form.This instruction lowering was crafted by studying LLVM's output and I've put commentary to the best of my ability as to what's going on.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Feb 12 2024 at 18:20):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #7919.
Wasmtime GitHub notifications bot (Feb 12 2024 at 18:20):alexcrichton requested fitzgen for a review on PR #7919.
Wasmtime GitHub notifications bot (Feb 12 2024 at 19:44):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Feb 12 2024 at 19:44):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Feb 12 2024 at 19:44):fitzgen created PR review comment:
:magic_wand:
Wasmtime GitHub notifications bot (Feb 12 2024 at 20:33):fitzgen merged PR #7919.
Last updated: Nov 22 2024 at 16:03 UTC