Stream: git-wasmtime

Topic: wasmtime / PR #7917 Shrink the size of int-to-float conve...

Wasmtime GitHub notifications bot (Feb 12 2024 at 17:29):

alexcrichton opened PR #7917 from alexcrichton:smaller-int-to-float to bytecodealliance:main:

This commit adds egraph optimization rules to shrink the size of int-to-float conversions where possible. This helps backends like the x64 backend where the 64-bit-unsigned-integer-to-float conversions does not have a single instruction lowering unlike other types.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Feb 12 2024 at 17:29):

alexcrichton requested abrown for a review on PR #7917.

Wasmtime GitHub notifications bot (Feb 12 2024 at 17:29):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #7917.

Wasmtime GitHub notifications bot (Feb 12 2024 at 18:44):

github-actions[bot] commented on PR #7917:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

• cfallin: isle
• fitzgen: isle

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Feb 14 2024 at 17:09):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Feb 14 2024 at 17:09):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Feb 14 2024 at 17:09):

abrown created PR review comment:

;; the chance to convert from the smallest integral type to the float. This

Wasmtime GitHub notifications bot (Feb 14 2024 at 17:43):

alexcrichton updated PR #7917.

Wasmtime GitHub notifications bot (Feb 14 2024 at 17:43):

alexcrichton has enabled auto merge for PR #7917.

Wasmtime GitHub notifications bot (Feb 14 2024 at 18:34):

alexcrichton merged PR #7917.

Last updated: Nov 22 2024 at 17:03 UTC