Stream: git-wasmtime

Topic: wasmtime / PR #7912 Update `ahash` dependency

Wasmtime GitHub notifications bot (Feb 10 2024 at 03:32):

alexcrichton requested wasmtime-default-reviewers for a review on PR #7912.

Wasmtime GitHub notifications bot (Feb 10 2024 at 03:32):

alexcrichton requested abrown for a review on PR #7912.

Wasmtime GitHub notifications bot (Feb 10 2024 at 03:32):

alexcrichton opened PR #7912 from alexcrichton:update-ahash to bytecodealliance:main:

This fixes the build on the latest nightly Rust. I was able to vet ahash itself but zerocopy is such a large and full-of-unsafe dependency I've added an exemption for it. The documentation of it seems to indicate it's a pretty well thought out crate with lots of care behind it, so at least at a first glance it did not seem overly worrisome.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Feb 10 2024 at 03:32):

alexcrichton edited PR #7912:

This fixes the build on the latest nightly Rust. I was able to vet ahash itself but zerocopy is such a large and full-of-unsafe dependency I've added an exemption for it. The documentation of it seems to indicate it's a pretty well thought out crate with lots of care behind it, so at least at a first glance it did not seem overly worrisome.

Closes #7896

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Feb 10 2024 at 04:10):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Feb 10 2024 at 04:39):

abrown merged PR #7912.

Last updated: Dec 23 2024 at 12:05 UTC