Stream: git-wasmtime

Topic: wasmtime / PR #7906 Fix assertion locations in memflags a...

Wasmtime GitHub notifications bot (Feb 09 2024 at 19:00):

elliottt requested fitzgen for a review on PR #7906.

Wasmtime GitHub notifications bot (Feb 09 2024 at 19:00):

elliottt requested wasmtime-compiler-reviewers for a review on PR #7906.

Wasmtime GitHub notifications bot (Feb 09 2024 at 19:00):

elliottt opened PR #7906 from elliottt:trevor/assertion-locations to bytecodealliance:main:

In #7903 I reworked the set and with functions on MemFlags to use the with variant internally, to enable further use of const. However, I didn't move the assertions from the set to the with methods, meaning that there was now a path that would avoid them. This follow-up fixes that mistake by moving the assertions into the with functions.
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Feb 09 2024 at 19:01):

elliottt edited PR #7906.

Wasmtime GitHub notifications bot (Feb 09 2024 at 19:33):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Feb 09 2024 at 19:59):

alexcrichton merged PR #7906.

Last updated: Dec 23 2024 at 12:05 UTC