Stream: git-wasmtime

Topic: wasmtime / PR #7903 Make some MemFlags functions const

Wasmtime GitHub notifications bot (Feb 09 2024 at 16:49):

elliottt opened PR #7903 from elliottt:trevor/const-memflags to bytecodealliance:main:

Switch the setter operations on MemFlags to use const functions internally,
allowing the with interface to become const. This allows for MemFlags
values to be defined as constant, and removes the need to cache trusted and
untrusted values in the winch x64 macro assembler.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Feb 09 2024 at 16:49):

elliottt requested wasmtime-compiler-reviewers for a review on PR #7903.

Wasmtime GitHub notifications bot (Feb 09 2024 at 16:49):

elliottt requested abrown for a review on PR #7903.

Wasmtime GitHub notifications bot (Feb 09 2024 at 16:49):

elliottt edited PR #7903:

Switch the setter operations on MemFlags to use const functions internally, allowing the with interface to become const. This allows for MemFlags values to be defined as constant, and removes the need to cache trusted and untrusted values in the winch x64 macro assembler.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Feb 09 2024 at 16:51):

elliottt requested saulecabrera for a review on PR #7903.

Wasmtime GitHub notifications bot (Feb 09 2024 at 16:53):

elliottt updated PR #7903.

Wasmtime GitHub notifications bot (Feb 09 2024 at 17:02):

elliottt updated PR #7903.

Wasmtime GitHub notifications bot (Feb 09 2024 at 17:06):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Feb 09 2024 at 17:06):

fitzgen has enabled auto merge for PR #7903.

Wasmtime GitHub notifications bot (Feb 09 2024 at 17:12):

saulecabrera created PR review comment:

When I was looking at this, I had thought of defining them where the MacroAssesmbler trait is defined, because they'll probably be consumed by all the other ISAs. Do you think it makes sense to move them over?

Wasmtime GitHub notifications bot (Feb 09 2024 at 17:12):

saulecabrera submitted PR review:

Left one minor suggestion. Thanks for adding this!

Wasmtime GitHub notifications bot (Feb 09 2024 at 17:12):

saulecabrera submitted PR review:

Left one minor suggestion. Thanks for adding this!

Wasmtime GitHub notifications bot (Feb 09 2024 at 17:12):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Feb 09 2024 at 17:12):

elliottt created PR review comment:

That's a great idea! I'll move them over :+1:

Wasmtime GitHub notifications bot (Feb 09 2024 at 17:13):

saulecabrera edited PR review comment.

Wasmtime GitHub notifications bot (Feb 09 2024 at 17:22):

elliottt updated PR #7903.

Wasmtime GitHub notifications bot (Feb 09 2024 at 18:35):

elliottt merged PR #7903.

Last updated: Oct 23 2024 at 20:03 UTC