Stream: git-wasmtime

Topic: wasmtime / PR #7897 Fix test pooling_allocator::instance_...

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2024 at 18:40):

cardoso requested fitzgen for a review on PR #7897.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2024 at 18:40):

cardoso requested wasmtime-core-reviewers for a review on PR #7897.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2024 at 18:40):

cardoso opened PR #7897 from cardoso:pooling_allocator/instance_too_large to bytecodealliance:main:

I noticed this test was failing with the wmemcheck feature enabled. Instead of disabling the test, I special-cased the expectations, but I'm happy to change the approach.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2024 at 18:41):

cardoso edited PR #7897:

I noticed this test was failing with the wmemcheck feature enabled. Instead of disabling the test, I special-cased the expectations, but I'm happy to change the approach.

I'm developing on aarch64 (M1 Max) in case other platforms exhibit different behavior.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2024 at 18:57):

fitzgen submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2024 at 18:57):

fitzgen has enabled auto merge for PR #7897.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2024 at 19:34):

fitzgen merged PR #7897.

Last updated: Dec 23 2024 at 12:05 UTC