Wasmtime GitHub notifications bot (Feb 06 2024 at 19:34): Wasmtime GitHub notifications bot (Feb 06 2024 at 19:34):elliottt requested wasmtime-compiler-reviewers for a review on PR #7879.
Wasmtime GitHub notifications bot (Feb 06 2024 at 19:34):elliottt opened PR #7879 from elliottt:trevor/subsume-use to bytecodealliance:main:
Take a quick pass over the egraph rules to look for cases that violate our new guidelines about when
subsumeis required. There were a few cases wheresubsumewas needed, and though I believe those instances were benign I think they're worth adding to make sure we're following the spirit of our new guidelines.I've also added some clarifying text about constants in the test of guideline 2, to make it more obvious that cases where we discard constants are okay without
subsume.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Feb 06 2024 at 19:34):elliottt requested abrown for a review on PR #7879.
Wasmtime GitHub notifications bot (Feb 06 2024 at 19:35):elliottt edited PR #7879:
I took a quick pass over the egraph rules to look for cases that violate our new guidelines about when
subsumeis required. There were a few cases wheresubsumewas needed, and though I believe those instances were benign I think they're worth adding to make sure we're following the spirit of our new guidelines.I've also added some clarifying text about constants in the test of guideline 2, to make it more obvious that cases where we discard constants are okay without
subsume.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Feb 06 2024 at 19:37):elliottt requested fitzgen for a review on PR #7879.
Wasmtime GitHub notifications bot (Feb 06 2024 at 19:37):elliottt edited PR #7879:
I took a quick pass over the egraph rules to look for cases that violate our new guidelines about when
subsumeis required. There were a few cases wheresubsumewas needed, and though I believe those instances were benign I think they're worth adding to make sure we're following the spirit of our new guidelines.I've also added some clarifying text about constants in the text of guideline 2, to make it more obvious that cases where we discard constants are okay without
subsume.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Feb 06 2024 at 20:15):fitzgen submitted PR review:
Thanks for auditing our rules!
Wasmtime GitHub notifications bot (Feb 06 2024 at 20:46):fitzgen merged PR #7879.
Last updated: Oct 23 2024 at 20:03 UTC