Stream: git-wasmtime

Topic: wasmtime / PR #7875 Update itertools to 0.12 in cranelift...

view this post on Zulip Wasmtime GitHub notifications bot (Feb 05 2024 at 23:42):

fornwall requested fitzgen for a review on PR #7875.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 05 2024 at 23:42):

fornwall requested wasmtime-compiler-reviewers for a review on PR #7875.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 05 2024 at 23:42):

fornwall requested wasmtime-default-reviewers for a review on PR #7875.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 05 2024 at 23:42):

fornwall opened PR #7875 from fornwall:itertools-0.12 to bytecodealliance:main:

Small dependency version bump to decrease duplicated crates in the dependency tree for consumers.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 06 2024 at 17:53):

fitzgen commented on PR #7875:

I've started the audit for the dep update.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 06 2024 at 20:09):

fitzgen commented on PR #7875:

Finished the audit: https://github.com/bytecodealliance/wasmtime/pull/7880

After that merges, we can rebase this PR and then it can merge as well.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 06 2024 at 23:05):

fitzgen commented on PR #7875:

The audit PR merged. @fornwall if you rebase on main, that should resolve the CI failures, and then we can merge this.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 07 2024 at 01:09):

fornwall updated PR #7875.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 07 2024 at 01:09):

fornwall commented on PR #7875:

The audit PR merged. @fornwall if you rebase on main, that should resolve the CI failures, and then we can merge this.

Done! Thanks.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 07 2024 at 01:12):

fornwall commented on PR #7875:

CI fails on itertools duplicated - should I update deny.toml? It's criterion which has not made a new release yet (but itertools will be updated in the next criterion release - https://github.com/bheisler/criterion.rs/blob/master/Cargo.toml#L26).

view this post on Zulip Wasmtime GitHub notifications bot (Feb 07 2024 at 01:13):

fornwall edited a comment on PR #7875:

CI fails on itertools duplicated - should I update deny.toml or await the next criterion release which fixes this (https://github.com/bheisler/criterion.rs/blob/master/Cargo.toml#L26)?

view this post on Zulip Wasmtime GitHub notifications bot (Feb 07 2024 at 14:15):

fitzgen commented on PR #7875:

It should be fine to add an exception to deny.toml for just itertools, and leave a TODO comment about fixing this in the next release of criterion.

Thanks for your patience with this PR!

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2024 at 03:16):

fornwall updated PR #7875.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2024 at 03:19):

fornwall commented on PR #7875:

@fitzgen Thanks, have added a deny.toml entry now.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2024 at 15:01):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2024 at 15:29):

alexcrichton merged PR #7875.

Last updated: Dec 23 2024 at 12:05 UTC