Wasmtime GitHub notifications bot (Jan 30 2024 at 00:51): Wasmtime GitHub notifications bot (Jan 30 2024 at 00:51):elliottt requested wasmtime-core-reviewers for a review on PR #7847.
Wasmtime GitHub notifications bot (Jan 30 2024 at 00:51):elliottt requested fitzgen for a review on PR #7847.
Wasmtime GitHub notifications bot (Jan 30 2024 at 00:51):elliottt opened PR #7847 from elliottt:trevor/fix-serve-epoch to bytecodealliance:main:
Using an epoch of
1and setting its duration to the full timeout configured does not work forwasmtime serve, as the epoch is counted globally per engine. This commit switches to dividing the timeout by 10, and expiring an instance after 11 epochs have been observed, giving a maximum overshoot of 10%.Co-authored-by: Jamey Sharp <jsharp@fastly.com>
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 30 2024 at 00:52):elliottt requested alexcrichton for a review on PR #7847.
Wasmtime GitHub notifications bot (Jan 30 2024 at 03:30):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jan 30 2024 at 04:06):alexcrichton merged PR #7847.
Last updated: Dec 23 2024 at 12:05 UTC