Stream: git-wasmtime

Topic: wasmtime / PR #7845 Replace an explicit implementation of...

Wasmtime GitHub notifications bot (Jan 30 2024 at 00:00):

elliottt opened PR #7845 from elliottt:trevor/service_fn to bytecodealliance:main:

Simplify the implementation of the serve command by removing the explicit Service trait impl, and using service_fn instead.

Co-authored-by: Jamey Sharp <jsharp@fastly.com>

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jan 30 2024 at 00:00):

elliottt requested alexcrichton for a review on PR #7845.

Wasmtime GitHub notifications bot (Jan 30 2024 at 00:00):

elliottt requested wasmtime-core-reviewers for a review on PR #7845.

Wasmtime GitHub notifications bot (Jan 30 2024 at 03:28):

alexcrichton submitted PR review:

Nice!

Wasmtime GitHub notifications bot (Jan 30 2024 at 03:56):

alexcrichton merged PR #7845.

Last updated: Dec 23 2024 at 12:05 UTC