alexcrichton opened PR #7842 from alexcrichton:fix-cross-compiled-funcref-mask
to bytecodealliance:main
:
Currently translation of Wasm code uses the
FUNCREF_MASK
constant which has typeusize
but this type is not always appropriate in cross-compiled situations. This commit fixes the usage ofFUNCREF_MASK
by using the platform-independent value (a negative value) along with some extra asserts and an explantation of how to update if necessary.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested fitzgen for a review on PR #7842.
alexcrichton requested wasmtime-core-reviewers for a review on PR #7842.
fitzgen submitted PR review.
fitzgen merged PR #7842.
Last updated: Dec 23 2024 at 12:05 UTC