Stream: git-wasmtime

Topic: wasmtime / PR #7842 Fix funcrefs cross-compiled between a...

Wasmtime GitHub notifications bot (Jan 29 2024 at 22:42):

alexcrichton opened PR #7842 from alexcrichton:fix-cross-compiled-funcref-mask to bytecodealliance:main:

Currently translation of Wasm code uses the FUNCREF_MASK constant which has type usize but this type is not always appropriate in cross-compiled situations. This commit fixes the usage of FUNCREF_MASK by using the platform-independent value (a negative value) along with some extra asserts and an explantation of how to update if necessary.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jan 29 2024 at 22:42):

alexcrichton requested fitzgen for a review on PR #7842.

Wasmtime GitHub notifications bot (Jan 29 2024 at 22:42):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7842.

Wasmtime GitHub notifications bot (Jan 29 2024 at 23:17):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jan 30 2024 at 00:05):

fitzgen merged PR #7842.

Last updated: Oct 23 2024 at 20:03 UTC