alexcrichton opened PR #7839 from alexcrichton:minor-refactorings
to bytecodealliance:main
:
This is a follow-up to #7766 with some more changes and reorganization. These are some small items here and there which shouldn't have any actual impact on functionality but are intended to reorganize a bit. Changes here include:
- Move component artifact definitions to
wasmtime-environ
as core module ones already live there.- Rename the module with module artifacts from
instantiate
tomodule_artifacts
.- Make
wasmtime-jit-icache-coherence
an optional dependency as only theruntime
feature requires it.- Reorganize serialized metadata for wasmtime ELF files to consolidate everything back into
wasmtime::engine::serialization
. This is to prevent the definition of the serialization format being spread across a few files.- Touching up the
serialization
module to compile in all builds of thewasmtime
crate.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested fitzgen for a review on PR #7839.
alexcrichton requested wasmtime-core-reviewers for a review on PR #7839.
github-actions[bot] commented on PR #7839:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
fitzgen submitted PR review.
fitzgen submitted PR review.
fitzgen created PR review comment:
//! * `runtime` - Enabled by default, this feature enables executing
fitzgen updated PR #7839.
fitzgen has enabled auto merge for PR #7839.
fitzgen merged PR #7839.
Last updated: Nov 22 2024 at 16:03 UTC