Stream: git-wasmtime

Topic: wasmtime / PR #7827 refactor demangling part in profiling.rs

Wasmtime GitHub notifications bot (Jan 26 2024 at 11:38):

high-cloud opened PR #7827 from high-cloud:demangle_wip to bytecodealliance:main:

…r_index

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
issue #7665
replace the match statement with a function already exist

Wasmtime GitHub notifications bot (Jan 26 2024 at 11:38):

high-cloud requested fitzgen for a review on PR #7827.

Wasmtime GitHub notifications bot (Jan 26 2024 at 11:38):

high-cloud requested wasmtime-core-reviewers for a review on PR #7827.

Wasmtime GitHub notifications bot (Jan 26 2024 at 12:48):

github-actions[bot] commented on PR #7827:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jan 26 2024 at 16:02):

fitzgen submitted PR review:

LGTM with minor nitpick below. Thanks!

Wasmtime GitHub notifications bot (Jan 26 2024 at 16:02):

fitzgen submitted PR review:

LGTM with minor nitpick below. Thanks!

Wasmtime GitHub notifications bot (Jan 26 2024 at 16:02):

fitzgen created PR review comment:

Could we change the unwrap to an expect where there is a brief message explaining why we expect this never to fail? Something like

        .expect("only errors if the Writer errors, and string writers never error");

Wasmtime GitHub notifications bot (Jan 27 2024 at 04:24):

high-cloud updated PR #7827.

Wasmtime GitHub notifications bot (Mar 12 2024 at 18:33):

elliottt commented on PR #7827:

Would you mind rebasing this PR? Once that's done, I'm happy to click the merge button :+1:

Wasmtime GitHub notifications bot (Mar 13 2024 at 17:32):

high-cloud updated PR #7827.

Wasmtime GitHub notifications bot (Mar 13 2024 at 22:29):

elliottt merged PR #7827.

Last updated: Nov 22 2024 at 17:03 UTC