Wasmtime GitHub notifications bot (Jan 26 2024 at 01:36): Wasmtime GitHub notifications bot (Jan 26 2024 at 01:36):fitzgen opened PR #7826 from fitzgen:rename-signature-to-type to bytecodealliance:main:
No functional changes, just the following mechanical renames:
VMSharedSignatureIndextoVMSharedTypeIndexSignatureIndextoTypeIndexSignatureRegistrytoTypeRegistry- and more
This is intended to start paving the way for Wasm GC support, where there are more than just function signatures in a Wasm module's type section, and we are going to need to register non-function-signature types in the registry as well, for things like casting between reference types and passing reference types across Wasm modules.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 26 2024 at 01:36):fitzgen requested wasmtime-compiler-reviewers for a review on PR #7826.
Wasmtime GitHub notifications bot (Jan 26 2024 at 01:36):fitzgen requested elliottt for a review on PR #7826.
Wasmtime GitHub notifications bot (Jan 26 2024 at 01:36):fitzgen requested pchickey for a review on PR #7826.
Wasmtime GitHub notifications bot (Jan 26 2024 at 01:36):fitzgen requested wasmtime-core-reviewers for a review on PR #7826.
Wasmtime GitHub notifications bot (Jan 26 2024 at 01:37):fitzgen updated PR #7826.
Wasmtime GitHub notifications bot (Jan 26 2024 at 01:53):fitzgen requested alexcrichton for a review on PR #7826.
Wasmtime GitHub notifications bot (Jan 26 2024 at 01:57):fitzgen commented on PR #7826:
Flagging @alexcrichton in particular for this review because I realized that we actually already had
wasm_types::TypeIndexand AFAICT it is actually the same aswasm_types::SignatureIndexand so, in the process of fixing compile errors, I deleted the duplicate definition ofTypeIndex(that used to beSignatureIndex) and everything is using the originalTypeIndexnow. But that is a little surprising, and I want to make sure that this isn't going to introduce any subtle bugs. Thoughts?
Wasmtime GitHub notifications bot (Jan 26 2024 at 01:59):fitzgen updated PR #7826.
Wasmtime GitHub notifications bot (Jan 26 2024 at 03:44):github-actions[bot] commented on PR #7826:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:wasm", "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Jan 26 2024 at 21:56):fitzgen updated PR #7826.
Wasmtime GitHub notifications bot (Jan 26 2024 at 21:57):fitzgen commented on PR #7826:
@alexcrichton I added a second commit that reintroduces separate index types for wasm-index-space types vs module-interned types.
Going to work on rebasing and resolving conflicts now.
Wasmtime GitHub notifications bot (Jan 26 2024 at 22:03):fitzgen updated PR #7826.
Wasmtime GitHub notifications bot (Jan 26 2024 at 22:03):fitzgen commented on PR #7826:
Rebased.
Wasmtime GitHub notifications bot (Jan 26 2024 at 23:02):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jan 26 2024 at 23:22):fitzgen updated PR #7826.
Wasmtime GitHub notifications bot (Jan 26 2024 at 23:24):fitzgen has enabled auto merge for PR #7826.
Wasmtime GitHub notifications bot (Jan 27 2024 at 00:23):fitzgen merged PR #7826.
Last updated: Dec 23 2024 at 12:05 UTC