Wasmtime GitHub notifications bot (Jan 24 2024 at 23:09): Wasmtime GitHub notifications bot (Jan 24 2024 at 23:09):alexcrichton opened PR #7816 from alexcrichton:close-intermediate-streams to bytecodealliance:main:
Previously temporary streams created as part of the preview1 adapter in the wasmtime-wasi crate were left open which meant that they continued to occupy space in the resource table and the underlying file accidentally wasn't ever actually closed.
cc #7813
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 24 2024 at 23:09):alexcrichton requested wasmtime-core-reviewers for a review on PR #7816.
Wasmtime GitHub notifications bot (Jan 24 2024 at 23:09):alexcrichton requested fitzgen for a review on PR #7816.
Wasmtime GitHub notifications bot (Jan 24 2024 at 23:10):pchickey submitted PR review:
Nice find! Glad this was easy to fix
Wasmtime GitHub notifications bot (Jan 25 2024 at 00:18):alexcrichton merged PR #7816.
Last updated: Dec 23 2024 at 12:05 UTC