Wasmtime GitHub notifications bot (Jan 24 2024 at 20:14): Wasmtime GitHub notifications bot (Jan 24 2024 at 20:14):womeier opened PR #7811 from womeier:main to bytecodealliance:main:
The tail call proposal configuration option is not yet exposed by the C api.
This change will allow configuring the option in e.g. the python library bindings:
https://github.com/bytecodealliance/wasmtime-py/issues/204<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 24 2024 at 20:15):womeier edited PR #7811.
Wasmtime GitHub notifications bot (Jan 24 2024 at 21:12):womeier edited PR #7811:
The tail call proposal configuration option is not yet exposed by the C api.
This change will allow configuring the option in e.g. the python library bindings:
https://github.com/bytecodealliance/wasmtime-py/issues/204I wanted to test this change doing the following:
It says in the docs, that running
cargo build --release --manifest-path crates/c-api/Cargo.tomlwill placelibwasmtime.{a,so}intarget/release.The command succeeds, but the file is not generated (and I cannot find libwasmtime.so with find).
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 24 2024 at 21:13):womeier edited PR #7811:
The tail call proposal configuration option is not yet exposed by the C api.
This change will allow configuring the option in e.g. the python library bindings:
https://github.com/bytecodealliance/wasmtime-py/issues/204I wanted to test this change doing the following:
It says in the docs, that running
cargo build --release --manifest-path crates/c-api/Cargo.tomlwill placelibwasmtime.{a,so}intarget/release.
The command succeeds, but the file is not generated (and I cannot find libwasmtime.so with find).<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 24 2024 at 21:16):womeier has marked PR #7811 as ready for review.
Wasmtime GitHub notifications bot (Jan 24 2024 at 21:16):womeier requested pchickey for a review on PR #7811.
Wasmtime GitHub notifications bot (Jan 24 2024 at 21:16):womeier requested wasmtime-core-reviewers for a review on PR #7811.
Wasmtime GitHub notifications bot (Jan 24 2024 at 21:17):womeier edited PR #7811:
The tail call proposal configuration option is not yet exposed by the C api.
This change will allow configuring the option in e.g. the python library bindings:
https://github.com/bytecodealliance/wasmtime-py/issues/204I wanted to test this change doing the following:
Following the docs, I ran
cargo build --release --manifest-path crates/c-api/Cargo.tomlwill placelibwasmtime.{a,so}intarget/release.
The command succeeded, but the file is not generated (and I cannot find libwasmtime.so with find).<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 24 2024 at 21:17):womeier edited PR #7811:
The tail call proposal configuration option is not yet exposed by the C api.
This change will allow configuring the option in e.g. the python library bindings:
https://github.com/bytecodealliance/wasmtime-py/issues/204I wanted to test this change doing the following:
Following the docs, I ran
cargo build --release --manifest-path crates/c-api/Cargo.tomlwill placelibwasmtime.{a,so}intarget/release.
The command succeeded, but the file is not generated (and I cannot find libwasmtime.so withfind).<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 24 2024 at 21:20):womeier edited PR #7811:
The tail call proposal configuration option is not yet exposed by the C api.
This change intends to allow configuring the option in e.g. the python library bindings:
https://github.com/bytecodealliance/wasmtime-py/issues/204I wanted to test this change doing the following:
Following the docs, I ran
cargo build --release --manifest-path crates/c-api/Cargo.tomlwill placelibwasmtime.{a,so}intarget/release.
The command succeeded, but the file is not generated (and I cannot find libwasmtime.so withfind).<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 24 2024 at 21:23):womeier edited PR #7811:
The tail call proposal configuration option is not yet exposed by the C api.
This change intends to allow configuring the option in e.g. the python library bindings:
https://github.com/bytecodealliance/wasmtime-py/issues/204I wanted to test this change doing the following:
Following the docs, I ran
cargo build --release --manifest-path crates/c-api/Cargo.tomlwill placelibwasmtime.{a,so}intarget/release.
The command succeeded, but the file is not generated (and I cannot find libwasmtime.so withfind).I thus didn't test the change further than the fact that it compiles.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 24 2024 at 21:29):womeier edited PR #7811:
The tail call proposal configuration option is not yet exposed by the C api.
This change intends to allow configuring the option in e.g. the python library bindings:
https://github.com/bytecodealliance/wasmtime-py/issues/204I wanted to test this change doing the following:
Following the docs, I ran
cargo build --release --manifest-path crates/c-api/Cargo.tomlwill placelibwasmtime.{a,so}intarget/release.
The command succeeded, but the file is not generated (and I cannot find libwasmtime.so withfind).I thus didn't test the change further than the fact that it compiles, in particular I didn't yet test the change in the python library.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 24 2024 at 21:30):womeier edited PR #7811:
The tail call proposal configuration option is not yet exposed by the C api.
This change intends to allow configuring the option in e.g. the python library bindings:
https://github.com/bytecodealliance/wasmtime-py/issues/204I wanted to test this change doing the following:
Following the docs, I ran
cargo build --release --manifest-path crates/c-api/Cargo.tomlwill placelibwasmtime.{a,so}intarget/release.
The command succeeded, but the file is not generated (and I cannot find libwasmtime.so withfind).I thus didn't test the change further than the fact that it compiles, in particular I didn't yet test the change
with the python library.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 24 2024 at 21:33):alexcrichton commented on PR #7811:
Looks great to me, thanks! Apologies for the documentation but it's outdated. Nowadays the correct invocation is with
-p wasmtime-c-apiinstead of--manifest-path .... I'll send a separate PR to update those docs.
Wasmtime GitHub notifications bot (Jan 24 2024 at 21:41):womeier edited PR #7811:
The tail call proposal configuration option is not yet exposed by the C api.
This change intends to allow configuring the option in e.g. the python library bindings:
https://github.com/bytecodealliance/wasmtime-py/issues/204I wanted to test this change doing the following:
Following the docs, I ran
cargo build --release --manifest-path crates/c-api/Cargo.tomlwhich should placelibwasmtime.{a,so}intarget/release.
The command succeeded, but the file is not generated (and I cannot find libwasmtime.so withfind).I thus didn't test the change further than the fact that it compiles, in particular I didn't yet test the change
with the python library.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 24 2024 at 21:45):github-actions[bot] commented on PR #7811:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:c-api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:c-api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Jan 24 2024 at 22:01):womeier commented on PR #7811:
Thanks for the quick response @alexcrichton!
I created a PR with the changes to the python bindings, they work as expected together, i.e. I can run my wasm module with tail calls :)
Wasmtime GitHub notifications bot (Jan 24 2024 at 22:01):womeier edited a comment on PR #7811:
Thanks for the quick response @alexcrichton!
I created a PR with the changes to the python bindings, they work as expected together, i.e. I can run my wasm module with tail calls using the python lib :)
Wasmtime GitHub notifications bot (Jan 24 2024 at 22:13):womeier edited PR #7811:
The tail call proposal configuration option is not yet exposed by the C api.
This change intends to allow configuring the option in e.g. the python library bindings:
https://github.com/bytecodealliance/wasmtime-py/issues/204I wanted to test this change doing the following:
Following the docs, I ran
cargo build --release --manifest-path crates/c-api/Cargo.tomlwhich should placelibwasmtime.{a,so}intarget/release.
The command succeeded, but the file is not generated (and I cannot find libwasmtime.so withfind).~I thus didn't test the change further than the fact that it compiles, in particular I didn't yet test the change
with the python library.~
Tested to work together with the PR: https://github.com/bytecodealliance/wasmtime-py/pull/205 to the python bindings.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 24 2024 at 22:14):womeier edited PR #7811:
The tail call proposal configuration option is not yet exposed by the C api.
This change intends to allow configuring the option in e.g. the python library bindings:
https://github.com/bytecodealliance/wasmtime-py/issues/204I wanted to test this change doing the following:
Following the docs, I ran
cargo build --release --manifest-path crates/c-api/Cargo.tomlwhich should placelibwasmtime.{a,so}intarget/release.
The command succeeded, but the file is not generated (and I cannot find libwasmtime.so withfind).~I thus didn't test the change further than the fact that it compiles, in particular I didn't yet test the change
with the python library.~
Tested to work together with the PR: https://github.com/bytecodealliance/wasmtime-py/pull/205 adjusting the python bindings.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 24 2024 at 22:14):womeier edited PR #7811:
The tail call proposal configuration is not yet exposed by the C api.
This change intends to allow configuring the option in e.g. the python library bindings:
https://github.com/bytecodealliance/wasmtime-py/issues/204I wanted to test this change doing the following:
Following the docs, I ran
cargo build --release --manifest-path crates/c-api/Cargo.tomlwhich should placelibwasmtime.{a,so}intarget/release.
The command succeeded, but the file is not generated (and I cannot find libwasmtime.so withfind).~I thus didn't test the change further than the fact that it compiles, in particular I didn't yet test the change
with the python library.~
Tested to work together with the PR: https://github.com/bytecodealliance/wasmtime-py/pull/205 adjusting the python bindings.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 24 2024 at 22:17):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jan 24 2024 at 22:47):alexcrichton merged PR #7811.
Last updated: Nov 22 2024 at 17:03 UTC