Wasmtime GitHub notifications bot (Jan 19 2024 at 22:48): Wasmtime GitHub notifications bot (Jan 19 2024 at 22:48):elliottt opened PR #7798 from elliottt:trevor/winch-unwind-info to bytecodealliance:main:
Reuse cranelift's implementation of unwinding info for windows, allowing for traps to work properly in winch.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 20 2024 at 00:45):elliottt updated PR #7798.
Wasmtime GitHub notifications bot (Jan 20 2024 at 02:00):github-actions[bot] commented on PR #7798:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Jan 22 2024 at 17:35):elliottt updated PR #7798.
Wasmtime GitHub notifications bot (Jan 22 2024 at 17:36):elliottt updated PR #7798.
Wasmtime GitHub notifications bot (Jan 23 2024 at 17:14):elliottt updated PR #7798.
Wasmtime GitHub notifications bot (Jan 23 2024 at 17:38):elliottt updated PR #7798.
Wasmtime GitHub notifications bot (Jan 23 2024 at 18:41):elliottt updated PR #7798.
Wasmtime GitHub notifications bot (Jan 23 2024 at 22:32):elliottt updated PR #7798.
Wasmtime GitHub notifications bot (Jan 24 2024 at 01:21):elliottt updated PR #7798.
Wasmtime GitHub notifications bot (Jan 24 2024 at 07:24):elliottt updated PR #7798.
Wasmtime GitHub notifications bot (Jan 24 2024 at 07:47):elliottt updated PR #7798.
Wasmtime GitHub notifications bot (Jan 24 2024 at 17:46):elliottt updated PR #7798.
Wasmtime GitHub notifications bot (Jan 24 2024 at 18:26):elliottt edited PR #7798:
Reuse cranelift's implementation of unwinding info for windows, allowing for traps to work properly in winch.
TODO:
- [ ] Does the stack check need to be in the prologue?
[ ] How do we emit an
UnwindInfo::SaveReginstruction when we don't haveVRegregisters? (Converting between winch'sRegandRealReg)
<!--
Please make sure you include the following information:If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 24 2024 at 18:41):elliottt updated PR #7798.
Wasmtime GitHub notifications bot (Jan 24 2024 at 18:59):elliottt edited PR #7798:
Reuse cranelift's implementation of unwinding info for windows, allowing for traps to work properly in winch.
TODO:
- [x] Does the stack check need to be in the prologue?
[ ] How do we emit an
UnwindInfo::SaveReginstruction when we don't haveVRegregisters? (Converting between winch'sRegandRealReg)
<!--
Please make sure you include the following information:If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 24 2024 at 18:59):elliottt edited PR #7798:
Reuse cranelift's implementation of unwinding info for windows, allowing for traps to work properly in winch.
TODO:
- [x] Does the stack check need to be in the prologue? (no)
[ ] How do we emit an
UnwindInfo::SaveReginstruction when we don't haveVRegregisters? (Converting between winch'sRegandRealReg)
<!--
Please make sure you include the following information:If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 24 2024 at 19:35):elliottt updated PR #7798.
Wasmtime GitHub notifications bot (Jan 24 2024 at 19:35):elliottt updated PR #7798.
Wasmtime GitHub notifications bot (Jan 24 2024 at 19:35):elliottt edited PR #7798:
Reuse cranelift's implementation of unwinding info for windows, allowing for traps to work properly in winch.
TODO:
- [x] Does the stack check need to be in the prologue? (no)
[x] How do we emit an
UnwindInfo::SaveReginstruction when we don't haveVRegregisters? (Converting between winch'sRegandRealReg)
<!--
Please make sure you include the following information:If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 24 2024 at 19:35):elliottt edited PR #7798:
Reuse cranelift's implementation of unwinding info for windows, allowing for traps to work properly in winch.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 24 2024 at 19:41):elliottt updated PR #7798.
Wasmtime GitHub notifications bot (Jan 24 2024 at 19:52):elliottt updated PR #7798.
Wasmtime GitHub notifications bot (Jan 24 2024 at 20:18):elliottt updated PR #7798.
Wasmtime GitHub notifications bot (Jan 24 2024 at 20:18):elliottt updated PR #7798.
Last updated: Dec 23 2024 at 12:05 UTC