Stream: git-wasmtime

Topic: wasmtime / PR #7794 Rename generated structures to `Guest...

Wasmtime GitHub notifications bot (Jan 18 2024 at 18:57):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7794.

Wasmtime GitHub notifications bot (Jan 18 2024 at 18:57):

alexcrichton requested pchickey for a review on PR #7794.

Wasmtime GitHub notifications bot (Jan 18 2024 at 18:57):

alexcrichton opened PR #7794 from alexcrichton:fix-same-name to bytecodealliance:main:

This mirrors how traits for the host are all called Host and it avoids name clashes with types that share the name of the interface they are in.

I've also added some simple debugging of macro-generated code to get better error messages.

Closes #7775

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jan 18 2024 at 21:53):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Jan 18 2024 at 22:39):

alexcrichton merged PR #7794.

Last updated: Nov 22 2024 at 16:03 UTC