Wasmtime GitHub notifications bot (Jan 18 2024 at 09:03): Wasmtime GitHub notifications bot (Jan 18 2024 at 09:03):juntyr opened PR #7792 from juntyr:wasi-common-optional-wasmtime to bytecodealliance:main:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->I am trying to use
wasi-common(and thus alsowiggle) to provide a commonWasiCtximplementation that is reused betweenwasmtimeand a custom runtime (as briefly mentioned in https://github.com/bytecodealliance/wasmtime/issues/7776). At the moment, compiling these packages also compileswasmtime, which is not supported on my platform. I propose to add an enabled-by-default feature towasi-commonandwigglethat guards allwasmtime-specific code and allows both packages to be compiled without a dependency onwasmtimeusingdefault-features = false.
Wasmtime GitHub notifications bot (Jan 18 2024 at 09:03):juntyr requested wasmtime-default-reviewers for a review on PR #7792.
Wasmtime GitHub notifications bot (Jan 18 2024 at 09:03):juntyr requested wasmtime-core-reviewers for a review on PR #7792.
Wasmtime GitHub notifications bot (Jan 18 2024 at 09:03):juntyr requested fitzgen for a review on PR #7792.
Wasmtime GitHub notifications bot (Jan 18 2024 at 15:50):alexcrichton submitted PR review:
Thanks!
Wasmtime GitHub notifications bot (Jan 18 2024 at 16:06):juntyr updated PR #7792.
Wasmtime GitHub notifications bot (Jan 18 2024 at 17:29):alexcrichton merged PR #7792.
Last updated: Nov 22 2024 at 17:03 UTC