Stream: git-wasmtime

Topic: wasmtime / PR #7789 mpk: restore PKRU state when a fiber ...

view this post on Zulip Wasmtime GitHub notifications bot (Jan 18 2024 at 01:46):

abrown opened PR #7789 from abrown:pku-async to bytecodealliance:main:

Previously, when a fiber was suspended, other computation could change the PKRU state on the current CPU. This means that the fiber could be resumed with a different PKRU state. This could be bad, resulting in situations in which the fiber can access more memory slots than it should or cannot even access its own memory slots.

This change saves the PKRU state prior to a fiber being suspended. When the fiber resumes execution, that PKRU state is restored.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 18 2024 at 01:47):

abrown commented on PR #7789:

This probably needs an async_functions.rs test but I'm still struggling on how to craft a scenario that checks for this issue.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 18 2024 at 01:47):

abrown edited a comment on PR #7789:

This probably needs an async_functions.rs test but I'm still struggling with how to craft a scenario that checks for this issue.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 18 2024 at 03:44):

github-actions[bot] commented on PR #7789:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Jan 18 2024 at 17:04):

alexcrichton submitted PR review:

Looks good to me :+1:

With a test that fails without this change I think it's good-to-go.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 15 2024 at 00:28):

abrown updated PR #7789.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 15 2024 at 00:28):

abrown updated PR #7789.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 15 2024 at 00:41):

abrown updated PR #7789.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 15 2024 at 02:29):

abrown has marked PR #7789 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 15 2024 at 02:29):

abrown requested fitzgen for a review on PR #7789.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 15 2024 at 02:29):

abrown requested wasmtime-core-reviewers for a review on PR #7789.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 15 2024 at 16:41):

abrown requested alexcrichton for a review on PR #7789.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 15 2024 at 19:31):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 15 2024 at 20:13):

alexcrichton merged PR #7789.

Last updated: Dec 23 2024 at 12:05 UTC