Stream: git-wasmtime

Topic: wasmtime / PR #7788 mpk: add `--memory-protection-keys` t...

view this post on Zulip Wasmtime GitHub notifications bot (Jan 18 2024 at 00:44):

abrown opened PR #7788 from abrown:pku-cli to bytecodealliance:main:

This only adds MPK configuration to the new Wasmtime flags.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 18 2024 at 00:46):

abrown commented on PR #7788:

@alexcrichton, I don't expect the current CI run to pass: when I run this locally, I think the following command should fail with "memory protection keys require the pooling allocator" but it does not:

$ WASMTIME_NEW_CLI=1 cargo run -- run -O memory-protection-keys=y --invoke echo_f32 tests/all/cli_tests/simple.wat 1.1

view this post on Zulip Wasmtime GitHub notifications bot (Jan 18 2024 at 00:47):

abrown edited a comment on PR #7788:

@alexcrichton, I don't expect the current CI run to pass: when I run this locally, I think the following command should fail with "memory protection keys require the pooling allocator" but it does not:

$ WASMTIME_NEW_CLI=1 cargo run -- run -O memory-protection-keys=y --invoke echo_f32 tests/all/cli_tests/simple.wat 1.1

I'm not really sure what's going wrong but clearly something isn't right.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 18 2024 at 15:53):

alexcrichton submitted PR review:

Oh I think that's because the block of code here is only hit when -O pooling-allocator is passed, otherwise it's skipped entirely. The bail! may need to move outside the match_feature! block

view this post on Zulip Wasmtime GitHub notifications bot (Jan 18 2024 at 21:37):

abrown updated PR #7788.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 18 2024 at 22:31):

abrown has marked PR #7788 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 18 2024 at 22:31):

abrown requested wasmtime-core-reviewers for a review on PR #7788.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 18 2024 at 22:31):

abrown requested alexcrichton for a review on PR #7788.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 18 2024 at 22:57):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 19 2024 at 00:07):

abrown updated PR #7788.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 19 2024 at 00:07):

abrown has enabled auto merge for PR #7788.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 19 2024 at 16:23):

alexcrichton merged PR #7788.

Last updated: Nov 22 2024 at 17:03 UTC