Stream: git-wasmtime

Topic: wasmtime / PR #7781 wasi implementations: use rc-2024-01-...

view this post on Zulip Wasmtime GitHub notifications bot (Jan 16 2024 at 22:58):

pchickey requested fitzgen for a review on PR #7781.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 16 2024 at 22:58):

pchickey opened PR #7781 from bytecodealliance:pch/wasi-rc-2024-01-16 to bytecodealliance:main:

https://github.com/WebAssembly/wasi-sockets/pull/93 eliminates the ipv6-only sockopt getter and setter, and the ability for cross-stack ipv6 to ipv4 connections to take place, so these are bubbled out through the test suites.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 16 2024 at 22:58):

pchickey requested wasmtime-core-reviewers for a review on PR #7781.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 16 2024 at 22:59):

pchickey updated PR #7781.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 16 2024 at 23:16):

badeend submitted PR review:

I have one remark. Other than that: LGMT!

view this post on Zulip Wasmtime GitHub notifications bot (Jan 16 2024 at 23:16):

badeend created PR review comment:

This should attempt to connect to v6_listener_addr which was a IPv4-mapped-IPv6 address. The way you rewrote it, this call doesn't actually test the change.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 16 2024 at 23:16):

badeend submitted PR review:

I have one remark. Other than that: LGMT!

view this post on Zulip Wasmtime GitHub notifications bot (Jan 16 2024 at 23:16):

badeend created PR review comment:

See previous comment

view this post on Zulip Wasmtime GitHub notifications bot (Jan 16 2024 at 23:22):

sunfishcode submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 16 2024 at 23:35):

pchickey updated PR #7781.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 16 2024 at 23:36):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 16 2024 at 23:36):

pchickey created PR review comment:

Got it - thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Jan 16 2024 at 23:36):

pchickey has enabled auto merge for PR #7781.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 16 2024 at 23:38):

pchickey updated PR #7781.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 17 2024 at 00:23):

pchickey merged PR #7781.

Last updated: Nov 22 2024 at 16:03 UTC