Stream: git-wasmtime

Topic: wasmtime / PR #7773 Winch: Float conversion instructions

Wasmtime GitHub notifications bot (Jan 12 2024 at 15:19):

jeffcharles requested fitzgen for a review on PR #7773.

Wasmtime GitHub notifications bot (Jan 12 2024 at 15:19):

jeffcharles requested wasmtime-compiler-reviewers for a review on PR #7773.

Wasmtime GitHub notifications bot (Jan 12 2024 at 15:19):

jeffcharles opened PR #7773 from jeffcharles:winch-float-conversion-instructions to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Part of #6528. Adds support for the following instructions to Winch:

• i32.trunc_f32_s
• i32.trunc_f32_u
• i32.trunc_f64_s
• i32.trunc_f64_u
• i64.trunc_f32_s
• i64.trunc_f32_u
• i64.trunc_f64_s
• i64.trunc_f64_u
• i32.reinterpret_f32
• i64.reinterpret_f64
• f32.convert_i32_s
• f32.convert_i32_u
• f32.convert_i64_s
• f32.convert_i64_u
• f64.convert_i32_s
• f64.convert_i32_u
• f64.convert_i64_s
• f64.convert_i64_u
• f32.reinterpret_i32
• f64.reinterpret_i64
• f32.demote_f64
• f64.promote_f32

Wasmtime GitHub notifications bot (Jan 12 2024 at 15:19):

jeffcharles requested wasmtime-fuzz-reviewers for a review on PR #7773.

Wasmtime GitHub notifications bot (Jan 12 2024 at 15:19):

jeffcharles requested wasmtime-core-reviewers for a review on PR #7773.

Wasmtime GitHub notifications bot (Jan 12 2024 at 16:30):

saulecabrera submitted PR review:

LGTM, thanks!

Wasmtime GitHub notifications bot (Jan 12 2024 at 17:04):

jeffcharles commented on PR #7773:

Not sure why https://github.com/bytecodealliance/wasmtime/actions/runs/7504830983/job/20432782059 failed. Running cargo test --target=x86_64-apple-darwin -- wast::Winch --nocapture locally shows everything as passing.

Wasmtime GitHub notifications bot (Jan 12 2024 at 17:23):

saulecabrera commented on PR #7773:

It's because the conversion spec tests assert for traps https://github.com/bytecodealliance/wasmtime/pull/7773/files#diff-823efed0acf795e9245a551aadae26695321f840cbe4b51b12410b26bde35c45R70 and currently since Winch doesn't fully encode unwind information, any tests that trap will fail on Windows. You need to add the conversion suites that trap here https://github.com/bytecodealliance/wasmtime/blob/main/build.rs#L210

Wasmtime GitHub notifications bot (Jan 12 2024 at 19:03):

jeffcharles updated PR #7773.

Wasmtime GitHub notifications bot (Jan 12 2024 at 19:03):

jeffcharles requested wasmtime-default-reviewers for a review on PR #7773.

Wasmtime GitHub notifications bot (Jan 12 2024 at 20:19):

saulecabrera merged PR #7773.

Last updated: Dec 23 2024 at 12:05 UTC