Stream: git-wasmtime

Topic: wasmtime / PR #7771 [17.0.0] Backport fix x64 option i128...


view this post on Zulip Wasmtime GitHub notifications bot (Jan 11 2024 at 21:29):

bjorn3 opened PR #7771 from bjorn3:backport_fix_x64_option_i128_abi to bytecodealliance:release-17.0.0:

LLVM passes the tag in rax and the u128 val in rdx/rcx. Before this change Cranelift would pass the first half of the value in rdx and the second half using an implicit return value pointer.

Backport of https://github.com/bytecodealliance/wasmtime/pull/7770 to 17.0.0

view this post on Zulip Wasmtime GitHub notifications bot (Jan 11 2024 at 21:29):

bjorn3 requested fitzgen for a review on PR #7771.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 11 2024 at 21:29):

bjorn3 requested wasmtime-compiler-reviewers for a review on PR #7771.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 11 2024 at 21:31):

bjorn3 commented on PR #7771:

This only affects programs that use enable_llvm_abi_extensions, which is not Wasmtime. As such I think this ok to backport.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 11 2024 at 21:50):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 11 2024 at 21:57):

alexcrichton merged PR #7771.


Last updated: Dec 23 2024 at 12:05 UTC