Wasmtime GitHub notifications bot (Jan 11 2024 at 14:20): Wasmtime GitHub notifications bot (Jan 11 2024 at 14:20):adambratschikaye opened PR #7769 from adambratschikaye:abk/move-jit-to-wasmtime to bytecodealliance:main:
This refactoring has been discussed here: https://github.com/bytecodealliance/wasmtime/issues/7652
The
wasmtime-jitcrate is removed by moving the platform agnostic parts towasmtime-environand the remaining parts towasmtime.The goal of this is to simplify the crate organization and make it possible to add a
runtimefeature to thewasmtimecrate such thatwasmtimecan be build without theruntimefeature to enable Wasm compilation on targets that may not support actual Wasm execution (e.g.wasm32itself). A follow-up PR will add this feature.
Wasmtime GitHub notifications bot (Jan 11 2024 at 14:20):adambratschikaye requested fitzgen for a review on PR #7769.
Wasmtime GitHub notifications bot (Jan 11 2024 at 14:20):adambratschikaye requested wasmtime-core-reviewers for a review on PR #7769.
Wasmtime GitHub notifications bot (Jan 11 2024 at 14:20):adambratschikaye requested wasmtime-default-reviewers for a review on PR #7769.
Wasmtime GitHub notifications bot (Jan 11 2024 at 14:21):adambratschikaye commented on PR #7769:
There are two main commits with the first one moving parts into
environand the second moving the remaining parts towasmtime. If you'd prefer I could submit those as two separate PRs.
Wasmtime GitHub notifications bot (Jan 11 2024 at 16:08):alexcrichton submitted PR review:
Looks great to me, thanks again for working on this!
Wasmtime GitHub notifications bot (Jan 11 2024 at 16:11):alexcrichton commented on PR #7769:
Ah so this sort of refatoring is likely to break various bits and pieces of CI, so if you'd like you can push a commit with the phrase "prtest:full" somewhere in the commit message and that'll force full CI to run on this PR instead of just the few builders. That way you should be able to weed out all the build failures before it goes through the merge queue.
Wasmtime GitHub notifications bot (Jan 11 2024 at 18:44):github-actions[bot] commented on PR #7769:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:config", "wasmtime:docs"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Jan 11 2024 at 18:44):github-actions[bot] commented on PR #7769:
Label Messager: wasmtime:config
It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:
[ ] If you added a new
Configmethod, you wrote extensive documentation for
it.<details>
Our documentation should be of the following form:
```text
Short, simple summary sentence.More details. These details can be multiple paragraphs. There should be
information about not just the method, but its parameters and results as
well.Is this method fallible? If so, when can it return an error?
Can this method panic? If so, when does it panic?
Example
Optional example here.
```</details>
[ ] If you added a new
Configmethod, or modified an existing one, you
ensured that this configuration is exercised by the fuzz targets.<details>
For example, if you expose a new strategy for allocating the next instance
slot inside the pooling allocator, you should ensure that at least one of our
fuzz targets exercises that new strategy.Often, all that is required of you is to ensure that there is a knob for this
configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
of its nestedstructs).Rarely, this may require authoring a new fuzz target to specifically test this
configuration. See [our docs on fuzzing][fuzzing-docs] for more details.</details>
[ ] If you are enabling a configuration option by default, make sure that it
has been fuzzed for at least two weeks before turning it on by default.[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html
<details>
To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.
To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.</details>
Wasmtime GitHub notifications bot (Jan 15 2024 at 09:23):adambratschikaye updated PR #7769.
Wasmtime GitHub notifications bot (Jan 15 2024 at 09:26):adambratschikaye updated PR #7769.
Wasmtime GitHub notifications bot (Jan 15 2024 at 10:02):adambratschikaye updated PR #7769.
Wasmtime GitHub notifications bot (Jan 15 2024 at 11:34):adambratschikaye updated PR #7769.
Wasmtime GitHub notifications bot (Jan 15 2024 at 15:57):adambratschikaye commented on PR #7769:
Looks like the full pipeline is passing now.
Wasmtime GitHub notifications bot (Jan 15 2024 at 15:57):adambratschikaye requested alexcrichton for a review on PR #7769.
Wasmtime GitHub notifications bot (Jan 16 2024 at 17:49):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jan 16 2024 at 18:27):alexcrichton merged PR #7769.
Last updated: Nov 22 2024 at 16:03 UTC