meithecatte requested elliottt for a review on PR #7768.
meithecatte requested wasmtime-compiler-reviewers for a review on PR #7768.
meithecatte opened PR #7768 from meithecatte:explain-domtree
to bytecodealliance:main
:
I had a look at
egraph/domtree.rs
and spent a good few minutes confused by what exactly is happening. This PR adds some comments to explain how the data is represented, which should hopefully help the next person to look at this code grasp it much faster.In particular, I clarified the comment in
egraph.rs
to avoid implying thatDomTreeWithChildren
duplicates the parent pointers.
meithecatte updated PR #7768.
fitzgen submitted PR review:
Thanks!
fitzgen merged PR #7768.
Last updated: Dec 23 2024 at 12:05 UTC