Stream: git-wasmtime

Topic: wasmtime / PR #7768 Document internals of DomTreeWithChil...

view this post on Zulip Wasmtime GitHub notifications bot (Jan 11 2024 at 13:34):

meithecatte requested elliottt for a review on PR #7768.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 11 2024 at 13:34):

meithecatte requested wasmtime-compiler-reviewers for a review on PR #7768.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 11 2024 at 13:34):

meithecatte opened PR #7768 from meithecatte:explain-domtree to bytecodealliance:main:

I had a look at egraph/domtree.rs and spent a good few minutes confused by what exactly is happening. This PR adds some comments to explain how the data is represented, which should hopefully help the next person to look at this code grasp it much faster.

In particular, I clarified the comment in egraph.rs to avoid implying that DomTreeWithChildren duplicates the parent pointers.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 11 2024 at 13:47):

meithecatte updated PR #7768.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 16 2024 at 17:09):

fitzgen submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Jan 16 2024 at 17:49):

fitzgen merged PR #7768.

Last updated: Dec 13 2025 at 19:03 UTC