Stream: git-wasmtime

Topic: wasmtime / PR #7756 Switch winch's internal stack from a ...

Wasmtime GitHub notifications bot (Jan 05 2024 at 22:52):

elliottt opened PR #7756 from elliottt:trevor/winch-stack-vec to bytecodealliance:main:

It doesn't look like which needs to modify the front of the VecDeque that it uses to model the value stack, and can instead use a Vec. This shouldn't change functionality at all, but seems nice for documentation purposes, as I initially assumed that there must be operations modifying the front of the stack given the use of VecDeque.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jan 05 2024 at 22:52):

elliottt requested abrown for a review on PR #7756.

Wasmtime GitHub notifications bot (Jan 05 2024 at 22:52):

elliottt requested wasmtime-compiler-reviewers for a review on PR #7756.

Wasmtime GitHub notifications bot (Jan 05 2024 at 22:52):

elliottt requested saulecabrera for a review on PR #7756.

Wasmtime GitHub notifications bot (Jan 05 2024 at 23:06):

saulecabrera submitted PR review:

This looks reasonable to me, thanks!

Wasmtime GitHub notifications bot (Jan 05 2024 at 23:06):

saulecabrera has enabled auto merge for PR #7756.

Wasmtime GitHub notifications bot (Jan 05 2024 at 23:47):

saulecabrera merged PR #7756.

Last updated: Nov 22 2024 at 16:03 UTC