Stream: git-wasmtime

Topic: wasmtime / PR #7755 [17.0.0] Backport fix `fd_read` and `...

Wasmtime GitHub notifications bot (Jan 05 2024 at 17:19):

dicej opened PR #7755 from dicej:backport-7750 to bytecodealliance:release-17.0.0:

Previously, first_non_empty_{c}io_vec always returned Ok(None) for buffers residing in shared memories since they cannot, in general, safely be represented as slices. That caused e.g. wasi-libc to spin forever when trying to write to stdout using fd_write since it always got Ok(0) and never made progress.

This commit changes the return type of both functions to use GuestPtr instead of GuestSlice{Mut}, allowing safe access to shared guest memory.

Big thanks to Alex Crichton for narrowing this down and suggesting the fix.

Wasmtime GitHub notifications bot (Jan 05 2024 at 17:19):

dicej requested pchickey for a review on PR #7755.

Wasmtime GitHub notifications bot (Jan 05 2024 at 17:19):

dicej requested wasmtime-core-reviewers for a review on PR #7755.

Wasmtime GitHub notifications bot (Jan 05 2024 at 17:43):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jan 05 2024 at 17:53):

dicej merged PR #7755.

Last updated: Dec 23 2024 at 12:05 UTC