Stream: git-wasmtime

Topic: wasmtime / PR #7750 fix `fd_read` and `fd_write` for `was...

view this post on Zulip Wasmtime GitHub notifications bot (Jan 04 2024 at 22:05):

dicej opened PR #7750 from dicej:bug-7745 to bytecodealliance:main:

Previously, first_non_empty_{c}io_vec always returned Ok(None) for buffers residing in shared memories since they cannot, in general, safely be represented as slices. That caused e.g. wasi-libc to spin forever when trying to write to stdout using fd_write since it always got Ok(0) and never made progress.

This commit changes the return type of both functions to use GuestPtr instead of GuestSlice{Mut}, allowing safe access to shared guest memory.

Big thanks to Alex Crichton for narrowing this down and suggesting the fix.

Fixes #7745

view this post on Zulip Wasmtime GitHub notifications bot (Jan 04 2024 at 22:05):

dicej requested wasmtime-core-reviewers for a review on PR #7750.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 04 2024 at 22:05):

dicej requested pchickey for a review on PR #7750.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 04 2024 at 22:05):

dicej requested alexcrichton for a review on PR #7750.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 04 2024 at 22:10):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 05 2024 at 01:13):

alexcrichton merged PR #7750.

Last updated: Nov 22 2024 at 16:03 UTC