Stream: git-wasmtime

Topic: wasmtime / PR #7744 cmake: remove unused file copy


view this post on Zulip Wasmtime GitHub notifications bot (Jan 03 2024 at 21:19):

rockwotj opened PR #7744 from rockwotj:patch-1 to bytecodealliance:main:

The file copy added for shared libraries is not needed and unused, it's not done for static builds and everywhere refers to WASMTIME_BUILD_PRODUCT or the original file in cargo's output.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 03 2024 at 21:19):

rockwotj requested fitzgen for a review on PR #7744.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 03 2024 at 21:19):

rockwotj requested wasmtime-core-reviewers for a review on PR #7744.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 03 2024 at 22:44):

github-actions[bot] commented on PR #7744:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Jan 03 2024 at 23:04):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 03 2024 at 23:32):

alexcrichton merged PR #7744.


Last updated: Dec 23 2024 at 12:05 UTC