Wasmtime GitHub notifications bot (Dec 22 2023 at 17:59): Wasmtime GitHub notifications bot (Dec 22 2023 at 17:59):penguin-wwy requested fitzgen for a review on PR #7723.
Wasmtime GitHub notifications bot (Dec 22 2023 at 17:59):penguin-wwy requested wasmtime-compiler-reviewers for a review on PR #7723.
Wasmtime GitHub notifications bot (Dec 22 2023 at 17:59):penguin-wwy opened PR #7723 from penguin-wwy:fix_test_run to bytecodealliance:main:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
In testing.md doc, Thetest runcommand requires thetarget
https://github.com/bytecodealliance/wasmtime/blob/b583c54fda13b53dea362861125dd1e2ced1381d/cranelift/docs/testing.md?plain=1#L298-L300However, when executing the
clif-util runcommand (e.gclif-util run cranelift/filetests/filetests/runtests/const.clif), any file is found to fail. Because it is not allowed to specify atargetin thetest runcommand in the actual code.
https://github.com/bytecodealliance/wasmtime/blob/b583c54fda13b53dea362861125dd1e2ced1381d/cranelift/src/run.rs#L114-L117In this PR I've modified it to filter only on architectures, as described in the documentation. The host platform's native targets will be used to actually compile the tests.
Wasmtime GitHub notifications bot (Dec 22 2023 at 18:01):penguin-wwy updated PR #7723.
Wasmtime GitHub notifications bot (Jan 02 2024 at 17:25):fitzgen submitted PR review:
Thanks!
Wasmtime GitHub notifications bot (Jan 02 2024 at 18:51):alexcrichton merged PR #7723.
Last updated: Dec 23 2024 at 13:07 UTC