Stream: git-wasmtime

Topic: wasmtime / PR #7715 Fix `ty_half_width` in isle prelude

Wasmtime GitHub notifications bot (Dec 21 2023 at 03:35):

scottmcm requested wasmtime-compiler-reviewers for a review on PR #7715.

Wasmtime GitHub notifications bot (Dec 21 2023 at 03:35):

scottmcm requested fitzgen for a review on PR #7715.

Wasmtime GitHub notifications bot (Dec 21 2023 at 03:35):

scottmcm opened PR #7715 from scottmcm:fix-half-width to bytecodealliance:main:

I spent way too long trying to figure out how I'd gotten a rule wrong, only to find out that ty_half_width in ISLE was doing something different from Type::half_width in the rest of the codebase.

Thus this PR, which stops it having a custom implementation in ISLE and just calls the normal method. I think anywhere in ISLE rules that wants to exclude the other cases should be using fits_in_64 or similar, not having the ty_half_width extern do something surprising.

The existing uses

https://github.com/bytecodealliance/wasmtime/blob/37300d3f4b51e0e3374e3c4fc382b7603b065c8b/cranelift/codegen/src/isa/riscv64/lower.isle#L115-L123

are under ty_vec_fits_in_register already, so it's fine.

Wasmtime GitHub notifications bot (Dec 21 2023 at 16:50):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Dec 21 2023 at 17:19):

fitzgen merged PR #7715.

Last updated: Oct 23 2024 at 20:03 UTC