Wasmtime GitHub notifications bot (Dec 20 2023 at 13:16): Wasmtime GitHub notifications bot (Dec 20 2023 at 13:16):rvolosatovs opened PR #7712 from rvolosatovs:feat/resource-any-2-resource to bytecodealliance:main:
Closes #7704
Follow-up on #7688 (based on that PR for simplicity)
Wasmtime GitHub notifications bot (Dec 20 2023 at 13:16):rvolosatovs commented on PR #7712:
cc @alexcrichton
Wasmtime GitHub notifications bot (Dec 20 2023 at 13:17):rvolosatovs edited PR #7712:
Closes #7704
Follow-up on #7688 (based on that PR for simplicity)Once #7688 is merged, I'll rebase such that only https://github.com/bytecodealliance/wasmtime/pull/7712/commits/5b20daf013bf064a32c53aefc93e7d4d52473c86 would be in this PR. Also happy to move the commit it #7688 if you prefer
Wasmtime GitHub notifications bot (Dec 20 2023 at 13:17):rvolosatovs edited PR #7712:
Closes #7704
Follow-up on #7688 (based on that PR for simplicity)Once #7688 is merged, I'll rebase such that only https://github.com/bytecodealliance/wasmtime/pull/7712/commits/5b20daf013bf064a32c53aefc93e7d4d52473c86 would be in this PR. Also happy to move the commit to #7688 if you prefer
Wasmtime GitHub notifications bot (Dec 20 2023 at 15:44):github-actions[bot] commented on PR #7712:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Dec 21 2023 at 13:34):rvolosatovs updated PR #7712.
Wasmtime GitHub notifications bot (Dec 21 2023 at 13:36):rvolosatovs updated PR #7712.
Wasmtime GitHub notifications bot (Dec 22 2023 at 13:53):rvolosatovs updated PR #7712.
Wasmtime GitHub notifications bot (Jan 02 2024 at 20:56):alexcrichton submitted PR review:
Looks reasonable to me, thanks!
There's one minor API-design question where it's not possible to recover from this method if it fails due to consumption of the
ResourceAnyinput. That being said the main failure condition, the wrong type, can be tested manually ahead of time, so I think that's ok.
Wasmtime GitHub notifications bot (Jan 02 2024 at 20:56):alexcrichton submitted PR review:
Looks reasonable to me, thanks!
There's one minor API-design question where it's not possible to recover from this method if it fails due to consumption of the
ResourceAnyinput. That being said the main failure condition, the wrong type, can be tested manually ahead of time, so I think that's ok.
Wasmtime GitHub notifications bot (Jan 02 2024 at 20:56):alexcrichton created PR review comment:
Could these be changed to asserts to match
Resource::lift_from_index?
Wasmtime GitHub notifications bot (Jan 04 2024 at 10:29):rvolosatovs updated PR #7712.
Wasmtime GitHub notifications bot (Jan 04 2024 at 10:30):rvolosatovs has marked PR #7712 as ready for review.
Wasmtime GitHub notifications bot (Jan 04 2024 at 10:30):rvolosatovs requested pchickey for a review on PR #7712.
Wasmtime GitHub notifications bot (Jan 04 2024 at 10:30):rvolosatovs requested wasmtime-core-reviewers for a review on PR #7712.
Wasmtime GitHub notifications bot (Jan 04 2024 at 10:31):rvolosatovs requested alexcrichton for a review on PR #7712.
Wasmtime GitHub notifications bot (Jan 04 2024 at 15:59):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jan 04 2024 at 16:25):alexcrichton merged PR #7712.
Last updated: Nov 22 2024 at 17:03 UTC