Stream: git-wasmtime

Topic: wasmtime / PR #7702 More spaceship patterns

Wasmtime GitHub notifications bot (Dec 18 2023 at 22:33):

scottmcm opened PR #7702 from scottmcm:more-icmp-isle to bytecodealliance:main:

This is a continuation of #7636 that added the spaceship patterns.

In particular, I noticed that what Rust currently does in sort_by

https://github.com/rust-lang/rust/blob/bf9229a2e366b4c311f059014a4aa08af16de5d8/library/core/src/slice/mod.rs#L3008

is a simplification pattern that I'd missed, so this adds that, and a couple other related things I saw in the area.

Wasmtime GitHub notifications bot (Dec 18 2023 at 22:33):

scottmcm requested fitzgen for a review on PR #7702.

Wasmtime GitHub notifications bot (Dec 18 2023 at 22:33):

scottmcm requested wasmtime-compiler-reviewers for a review on PR #7702.

Wasmtime GitHub notifications bot (Dec 18 2023 at 22:34):

scottmcm submitted PR review.

Wasmtime GitHub notifications bot (Dec 18 2023 at 22:34):

scottmcm created PR review comment:

Specifically this truthy part:

https://github.com/bytecodealliance/wasmtime/blob/36b10914257e682ebdb3f91dac2e30515b394edb/cranelift/codegen/src/opts/bitops.isle#L106

Wasmtime GitHub notifications bot (Dec 19 2023 at 01:03):

github-actions[bot] commented on PR #7702:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

• cfallin: isle
• fitzgen: isle

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Dec 19 2023 at 21:12):

fitzgen submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (Dec 19 2023 at 21:40):

fitzgen merged PR #7702.

Last updated: Dec 23 2024 at 12:05 UTC