Stream: git-wasmtime

Topic: wasmtime / PR #7690 wasi-sockets: Add SO_REUSEADDR back in

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2023 at 17:27):

badeend requested fitzgen for a review on PR #7690.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2023 at 17:27):

badeend opened PR #7690 from badeend:reuseaddr to bytecodealliance:main:

In #7662 the call to bind_existing_tcp_listener was replaced with rustix::net::bind. Unfortunately, besides calling bind, bind_existing_tcp_listener also set SO_REUSEADDR. This PR restores that behavior. I've added an integration test and a note to the WITs too.

Unrelated: I also removed the workarounds in the Bind tests:

        // Concurrent invocations of this test can yield `AddressInUse` and that
        // same error can show up on Windows as `AccessDenied`.
        Err(ErrorCode::AddressInUse | ErrorCode::AccessDenied) => return,

by using a random generated port instead of a single constant.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2023 at 17:27):

badeend requested wasmtime-core-reviewers for a review on PR #7690.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2023 at 17:31):

badeend updated PR #7690.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2023 at 22:03):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 15 2023 at 14:34):

rylev submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 15 2023 at 14:34):

rylev submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 15 2023 at 14:34):

rylev created PR review comment:

        /// When binding to a non-zero port, this bind operation shouldn't be affected by the TIME_WAIT
        /// state of a recently closed socket on the same local address (i.e., the SO_REUSEADDR socket
        /// option should be set implicitly on platforms that require it).

view this post on Zulip Wasmtime GitHub notifications bot (Dec 17 2023 at 11:28):

badeend updated PR #7690.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 17 2023 at 11:44):

badeend commented on PR #7690:

This should be good to go again.

In ran into EADDRINUSE issues on my local machine when binding to a specific (but random) port. So I've modified the tests to give it a few attempts.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 17 2023 at 18:34):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 17 2023 at 19:18):

alexcrichton merged PR #7690.

Last updated: Nov 22 2024 at 16:03 UTC